Comment from @klonos

Other things I consider nice-to-haves for this:

  • Validation for the menu link title. I think that this field should be made required, but I understand that there is a bug currently with required fields that are hidden via #states (we could solve that the same way as in #2731). How it works currently is that you can tick the "Provide a menu link" checkbox, and may leave the the "Menu link title" field empty. What happens is that there is no validation error during form submit; the menu item is simply not created (which is odd UX if not a bug/WTF).
  • Ability to "lock" the menu creation and menu placement (same as we allow for the "Sticky" and "Promote" options).

Comment from @quicksketch

I was not able to apply your suggestions to the description text from the PR. They looked good to me. Could you file a follow-up PR for the unapplied changes from backdrop/backdrop#2999?

GitHub Link: 
https://github.com/backdrop/backdrop-issues/issues/4251
GitHub Issue #: 
4251