Description of the bug
We needed separate created and updated notifications for comments on a new Backdrop project. Unfortunately, the current state is that it always gives the "Your comment has been posted." message regardless if a comment was just created or updated. Nodes, on the other hand, have a separate message for update operation: "Post Your first post! has been updated.". So I believe this needs to be brought into consistency.
Additional information
This can be easily addressed by changing the following code in comment.module:
if ($comment->status == COMMENT_NOT_PUBLISHED) {
if (!user_access('administer comments')) {
backdrop_set_message(t('Your comment has been queued for review by site administrators and will be published after approval.'));
}
}
else {
backdrop_set_message(t('Your comment has been posted.'));
}
to
if ($comment->status == COMMENT_NOT_PUBLISHED) {
if (!user_access('administer comments')) {
backdrop_set_message(t('Your comment has been queued for review by site administrators and will be published after approval.'));
}
}
elseif (isset($comment->new)) {
backdrop_set_message(t('Your comment has been updated.'));
}
else {
backdrop_set_message(t('Your comment has been posted.'));
}
and I'll be filing a PR soon. However, what I find it strange is that the $comment->new is set and equals to FALSE only on updates whereas on new comment creation it's not there at all. So I am not sure if this is a separate bug, because semantically it makes more sense to use an if condition something like this:
if ($comment->new == TRUE) {
print created message here
}
else {
print updated message here
}
Let me know if we should chase why the $comment->new is not there for new comments or if the suggested PR is good enough.
Recent comments
Hi Kevin I am interested assisting you developing a theme by cloning feature from existing WordPress website. Please let me know your suitable time to discuss further...
Create a theme from existing website
I've updated the Zulip link in both places I found it. No need to post again, unless you have something new to say. We'll pull together feedback from all the sources.
Backdrop CMS Core Priorities
Should we post here again, what we posted over there? Or would that unnecessarily duplicate things? The link to a Zulip thread in this initial post leads to an internal one, but there's...
Backdrop CMS Core Priorities