Nine pull requests are currently marked RTBC - time to consider merging? Bug fixes mostly, and not too complex.
Issue #6987: There's a PoC PR for the "text field Tribbles" problem.
Issue #1528: Another rabbit hole with additional layout paths, it seems. But overall the new approach works pretty well. (Some feedback would be nice.)
Two issues would benefit from testing and code reviews; they've been around for a while and no takers. It would be a shame for these to miss the next releases.
PR improves it significantly but is not a perfect 100% fix at all zoom levels. However, we should not let the desire for perfection prevent incremental improvement.
If anyone has a suggestion to get it to 100%, I'm all ears.
No code reviews or testing yet. I have included a View definition in the issue that requires no additional test data (it is a view of modules) so it can be easily tested in the sandbox.
But when setting End Date, and relative of -0 days or -1 days...
Instead of "-0 days" use today and instead of -1 days use yesterday.
Find some background re relative...
Worth mentioning as it was in zulip chat by @yorkshirepudding
I just tested and the two work together without issue as long as you don't use the "Exclude comments from Content...
There is also Node Comments Search - this searches the node and all comments (default search is node and first page of comments) as part of the content search. Izzy's module above is a separate...
Posted2 weeks 1 day ago by Martin Price | System Horizons Ltd (yorkshirepudding) on:
Comments
For the dev meeting: Progress all over the place.
Nine pull requests are currently marked RTBC - time to consider merging? Bug fixes mostly, and not too complex.
Issue #6987: There's a PoC PR for the "text field Tribbles" problem.
Issue #1528: Another rabbit hole with additional layout paths, it seems. But overall the new approach works pretty well. (Some feedback would be nice.)
Two issues would benefit from testing and code reviews; they've been around for a while and no takers. It would be a shame for these to miss the next releases.
There are some test failures in the user module after merging in the latest commits.
Randomly, only in one PHP version - and always a different one.
See also this Zulip thread, yorkshirepudding.
Perhaps, these latest lines of random test failures can be considered in the meeting too?