Hello,
A quick question for the Ubercart experts.
In:
uc_cart_view()
Residing in:
ubercart/uc_cart/uc_cart.pages.inc
I have noticed that the breadcrumb is set quite late in the function, after the argument count sanity check and empty cart check.
- The argument count check immediately returns MENU_NOT_FOUND, which presumably results in a 404 (am I right?)
- The empty cart check immediately returns an array('#theme' => 'uc_empty_cart');
The custom breadcrumb is set last, so if the two above conditions are met it will never be evaluated.
But, to me, it looks like the discriminator for the custom breadcrumb is independent of arguments passed and cart contents, so I am wondering if that code block should actually be set earlier in the function (between or perhaps before these two above-mentioned checks)?
Here's the code, it appears to have no logical dependency on cart item count:
// Add a custom cart breadcrumb if specified.
if (($text = variable_get('uc_cart_breadcrumb_text', '')) !== '') {
$link = l($text, variable_get('uc_cart_breadcrumb_url', '<front>'));
drupal_set_breadcrumb(array($link));
}
Shouldn't this setting be evaluated regardless of arguments passed or an empty cart, or have I missed something?
g.
Recent comments
@ian I am getting lost what module are you using that is version 1.x-1.6.0 and 1.x-1.7.0 ?
Cloudflare specific advice needed
I'm also now getting a 403 when trying to access admin/reports/updates - it seems to be Backdrop generated but there is nothing in the Recent Log messages other than my login as admin...
Cloudflare specific advice needed
Since this is still possibly Cloudflare related I'll post here: I'm now experiencing what I think is caching issue - since installing Bee I've run bee cc all, bee cron, bee mm 1, then,...
Cloudflare specific advice needed
My thanks to you both... I understand now that Bee is not a module but a stand alone utility. I've installed it and see that it is similar to Drush which I have used before. I'll now...
Cloudflare specific advice needed
@ian Let's try to stay on the rails here. As the project page, https://backdropcms.org/project/bee, says: "Bee is a command line utility for Backdrop CMS." It is equivalent to drush. It is not...
Cloudflare specific advice needed