Hello,
A quick question for the Ubercart experts.
In:
uc_cart_view()
Residing in:
ubercart/uc_cart/uc_cart.pages.inc
I have noticed that the breadcrumb is set quite late in the function, after the argument count sanity check and empty cart check.
- The argument count check immediately returns MENU_NOT_FOUND, which presumably results in a 404 (am I right?)
- The empty cart check immediately returns an array('#theme' => 'uc_empty_cart');
The custom breadcrumb is set last, so if the two above conditions are met it will never be evaluated.
But, to me, it looks like the discriminator for the custom breadcrumb is independent of arguments passed and cart contents, so I am wondering if that code block should actually be set earlier in the function (between or perhaps before these two above-mentioned checks)?
Here's the code, it appears to have no logical dependency on cart item count:
// Add a custom cart breadcrumb if specified.
if (($text = variable_get('uc_cart_breadcrumb_text', '')) !== '') {
$link = l($text, variable_get('uc_cart_breadcrumb_url', '<front>'));
drupal_set_breadcrumb(array($link));
}
Shouldn't this setting be evaluated regardless of arguments passed or an empty cart, or have I missed something?
g.
Recent comments
Hi Editing I see this: The CSS looks like this: /* Level 1: Standard Numbers */ .field-name-body ol { list-style-type: decimal; } /* Level 2: Lowercase Letters */ .field...
Numbered List format is different when editing
Done: https://github.com/backdrop/backdrop-issues/issues/7097 Feel free to edit it with better technical language. I'll have ago at vaccinating it but I'm only a user and the...
Numbered List format is different when editing
Hi Mike. That looks like a bug. The CKE ordered lists when editing have the correct CSS to format those lists correctly, but when Backdrop displays the body field in Basis, it doesn't...
Numbered List format is different when editing
Restore Newsletter Subscriptions from a Dev Website In my last comment, I described a way to restore newsletter subscriptions from a database backup. The method involved directly editing...
Re-enable Simplenews newsletter subscriptions that had been erroneously disabled
I am considering migrating my drupal 7 website to backdrop. Hi @seamus, I would like to offer my professional services for migration to BackdropCMS. Please connect If...
drupal 7 to backdrop migration