Hello,
A quick question for the Ubercart experts.
In:
uc_cart_view()
Residing in:
ubercart/uc_cart/uc_cart.pages.inc
I have noticed that the breadcrumb is set quite late in the function, after the argument count sanity check and empty cart check.
- The argument count check immediately returns MENU_NOT_FOUND, which presumably results in a 404 (am I right?)
- The empty cart check immediately returns an array('#theme' => 'uc_empty_cart');
The custom breadcrumb is set last, so if the two above conditions are met it will never be evaluated.
But, to me, it looks like the discriminator for the custom breadcrumb is independent of arguments passed and cart contents, so I am wondering if that code block should actually be set earlier in the function (between or perhaps before these two above-mentioned checks)?
Here's the code, it appears to have no logical dependency on cart item count:
// Add a custom cart breadcrumb if specified.
if (($text = variable_get('uc_cart_breadcrumb_text', '')) !== '') {
$link = l($text, variable_get('uc_cart_breadcrumb_url', '<front>'));
drupal_set_breadcrumb(array($link));
}
Shouldn't this setting be evaluated regardless of arguments passed or an empty cart, or have I missed something?
g.
Recent comments
In a blog post titled "Github Tips and Tricks for Contrib Maintainers", I'd like to see some of the following topics: When is the README sufficient for documentation? When should...
Github Tips and Tricks for Contrib Maintainers
Thanks Alejandro. That was the clues I needed.
Ubercart - Programmatically add product to cart and straight to Checkout
Have you tried uc_cart_add_item()? You need to provide the nid of the product. Then you can use backdrop_goto('cart/checkout'); to send the user to the checkout screen. uc_cart_add_item...
Ubercart - Programmatically add product to cart and straight to Checkout
No problem, let's see how it evolves. I'd be happy to provide a suggested version if i could. I will keep that in mind and try learn this hook chain hopefully very soon. I will...
File hashing uploads made through TinyMCE
I could request hashing support, but that's the lazy way 🤣 I would appreciate it if you as an active maintainer would 'officially' add a hashing support...
File hashing uploads made through TinyMCE