Hello,
A quick question for the Ubercart experts.
In:
uc_cart_view()
Residing in:
ubercart/uc_cart/uc_cart.pages.inc
I have noticed that the breadcrumb is set quite late in the function, after the argument count sanity check and empty cart check.
- The argument count check immediately returns MENU_NOT_FOUND, which presumably results in a 404 (am I right?)
- The empty cart check immediately returns an array('#theme' => 'uc_empty_cart');
The custom breadcrumb is set last, so if the two above conditions are met it will never be evaluated.
But, to me, it looks like the discriminator for the custom breadcrumb is independent of arguments passed and cart contents, so I am wondering if that code block should actually be set earlier in the function (between or perhaps before these two above-mentioned checks)?
Here's the code, it appears to have no logical dependency on cart item count:
// Add a custom cart breadcrumb if specified.
if (($text = variable_get('uc_cart_breadcrumb_text', '')) !== '') {
$link = l($text, variable_get('uc_cart_breadcrumb_url', '<front>'));
drupal_set_breadcrumb(array($link));
}
Shouldn't this setting be evaluated regardless of arguments passed or an empty cart, or have I missed something?
g.
Recent comments
Works now after clearing the browser cache. The design has also solidified. It was at an image field's page. (Clearing the site cache had no effect). Hereby fixed, thank you...
1.30.1 - inbuilt Token Browser rows not expanding
Ow, it was the browser cache. The site cache (or cron) didn't do it. A good old devil in the details. :-) Thanks for the input!
1.30.1 - inbuilt Token Browser rows not expanding
I'm not seeing that issue (I just spinned out a fresh installation with 1.30.2). What's really weird is that you still have the "less / more" which shouldn't be there. Clear caches? Also...
1.30.1 - inbuilt Token Browser rows not expanding
Please try clearing caches if you haven't already. Please can you say what page this is happening on as I can't reproduce with a site on 1.30.1
1.30.1 - inbuilt Token Browser rows not expanding
If I recall correctly, Backdrop will not gzip if the page content is already gzipped. And it only happens if you've enabled page compression setting. But maybe that doesn't help here...
Documentation update