Hello,
A quick question for the Ubercart experts.
In:
uc_cart_view()
Residing in:
ubercart/uc_cart/uc_cart.pages.inc
I have noticed that the breadcrumb is set quite late in the function, after the argument count sanity check and empty cart check.
- The argument count check immediately returns MENU_NOT_FOUND, which presumably results in a 404 (am I right?)
- The empty cart check immediately returns an array('#theme' => 'uc_empty_cart');
The custom breadcrumb is set last, so if the two above conditions are met it will never be evaluated.
But, to me, it looks like the discriminator for the custom breadcrumb is independent of arguments passed and cart contents, so I am wondering if that code block should actually be set earlier in the function (between or perhaps before these two above-mentioned checks)?
Here's the code, it appears to have no logical dependency on cart item count:
// Add a custom cart breadcrumb if specified.
if (($text = variable_get('uc_cart_breadcrumb_text', '')) !== '') {
$link = l($text, variable_get('uc_cart_breadcrumb_url', '<front>'));
drupal_set_breadcrumb(array($link));
}
Shouldn't this setting be evaluated regardless of arguments passed or an empty cart, or have I missed something?
g.
Recent comments
Thank you for providing the links to the Ckeditor 5 problem when using the gin theme that may occur after updating Backdrop to the 1.32.0 release, and the link to the new release of gin that...
Backdrop CMS 1.32.0 Upgrade Issues or Feedback
Here is a possibly related issue in the core issue queue: After upgrade from 1.31.1 to 1.32.0 update.php shows fatal errors and leaves site in maintenance mode https://github.com/...
Backdrop CMS 1.32.0 Upgrade Issues or Feedback
It sounds like a CSS/JS bug in the Layouts UI: when the "Add block" row is hidden with display:none, its help/description element isn’t being hidden together. 🔧 Things to try...
Add blocks filtering problem
It is an admin theme that's based upon the bootstrap 3. Maybe it's missing a piece to act as an admin theme?
Add blocks filtering problem
Thank you, Martin and Olaf! I had a feeling that there might be something out there already :) I will check all three options (I will look at porting modules) and report back which one...
Filter by text in "message" in /admin/reports/dblog