Hello,
A quick question for the Ubercart experts.
In:
uc_cart_view()
Residing in:
ubercart/uc_cart/uc_cart.pages.inc
I have noticed that the breadcrumb is set quite late in the function, after the argument count sanity check and empty cart check.
- The argument count check immediately returns MENU_NOT_FOUND, which presumably results in a 404 (am I right?)
- The empty cart check immediately returns an array('#theme' => 'uc_empty_cart');
The custom breadcrumb is set last, so if the two above conditions are met it will never be evaluated.
But, to me, it looks like the discriminator for the custom breadcrumb is independent of arguments passed and cart contents, so I am wondering if that code block should actually be set earlier in the function (between or perhaps before these two above-mentioned checks)?
Here's the code, it appears to have no logical dependency on cart item count:
// Add a custom cart breadcrumb if specified.
if (($text = variable_get('uc_cart_breadcrumb_text', '')) !== '') {
$link = l($text, variable_get('uc_cart_breadcrumb_url', '<front>'));
drupal_set_breadcrumb(array($link));
}
Shouldn't this setting be evaluated regardless of arguments passed or an empty cart, or have I missed something?
g.
Recent comments
Sorry for not being clear. I have this view and two exposed filters on it. I am trying to show different places on the map. These places are called "institutions". They have a...
Parent items won't show on Leaflet Widget.
Still trying to understand: you have this view and an exposed form on it, right. And you have two independent taxonomy terms and try to filter by them? Or is this a hierarchal...
Parent items won't show on Leaflet Widget.
Sorry. It is a taxonomy term.
Parent items won't show on Leaflet Widget.
Hi geoma, hm... I'm not quite sure, what "parent" means in that context. Is it a taxonomy term? Or a related node type? The map will only show geo data from the field...
Parent items won't show on Leaflet Widget.
Hi geoma, How can I Include more info in the popup In a view or in the popup of the field display on nodes? In fields you can use tokens for field display...
Customizing Leaflet Widget popup content and appearance.