Hello,
A quick question for the Ubercart experts.
In:
uc_cart_view()
Residing in:
ubercart/uc_cart/uc_cart.pages.inc
I have noticed that the breadcrumb is set quite late in the function, after the argument count sanity check and empty cart check.
- The argument count check immediately returns MENU_NOT_FOUND, which presumably results in a 404 (am I right?)
- The empty cart check immediately returns an array('#theme' => 'uc_empty_cart');
The custom breadcrumb is set last, so if the two above conditions are met it will never be evaluated.
But, to me, it looks like the discriminator for the custom breadcrumb is independent of arguments passed and cart contents, so I am wondering if that code block should actually be set earlier in the function (between or perhaps before these two above-mentioned checks)?
Here's the code, it appears to have no logical dependency on cart item count:
// Add a custom cart breadcrumb if specified.
if (($text = variable_get('uc_cart_breadcrumb_text', '')) !== '') {
$link = l($text, variable_get('uc_cart_breadcrumb_url', '<front>'));
drupal_set_breadcrumb(array($link));
}
Shouldn't this setting be evaluated regardless of arguments passed or an empty cart, or have I missed something?
g.
Recent comments
Trying to push it to upstream 🤞 https://github.com/drush-ops/drush/pull/6621
Using Drush 8 with php 8
Wow, thank you!
Using Drush 8 with php 8
Hi folks, I went ahead and ported all drush 8.x stuff to PHP 8.3 and completely ripped out the legacy Symfony 2 internals. You can check out the exact details of what was done in the PR...
Using Drush 8 with php 8
The inability to check for and install updates makes website development and maintenance extremely difficult. Managing over ten websites across two different hosting providers—one of which is...
Unable to run update - fails with Connection timed out
Thanks for the response, Herb! Since I posted that I did some more testing and have posted this issue https://github.com/backdrop-contrib/tfa_basic/issues/33 In fact, if both email...
TFA - how to setup fallback options 'per user'