Hello,
A quick question for the Ubercart experts.
In:
uc_cart_view()
Residing in:
ubercart/uc_cart/uc_cart.pages.inc
I have noticed that the breadcrumb is set quite late in the function, after the argument count sanity check and empty cart check.
- The argument count check immediately returns MENU_NOT_FOUND, which presumably results in a 404 (am I right?)
- The empty cart check immediately returns an array('#theme' => 'uc_empty_cart');
The custom breadcrumb is set last, so if the two above conditions are met it will never be evaluated.
But, to me, it looks like the discriminator for the custom breadcrumb is independent of arguments passed and cart contents, so I am wondering if that code block should actually be set earlier in the function (between or perhaps before these two above-mentioned checks)?
Here's the code, it appears to have no logical dependency on cart item count:
// Add a custom cart breadcrumb if specified.
if (($text = variable_get('uc_cart_breadcrumb_text', '')) !== '') {
$link = l($text, variable_get('uc_cart_breadcrumb_url', '<front>'));
drupal_set_breadcrumb(array($link));
}
Shouldn't this setting be evaluated regardless of arguments passed or an empty cart, or have I missed something?
g.
Recent comments
Here’s an improved version of the reply including SEO keywords (meta description, SEO, page layout, HTML head tags, etc.) while keeping it professional and relevant: If your page is...
Meta tag description on a page created by a layout
https://github.com/backdrop/backdrop-issues/issues/7018 Feel free to edit as you see fit. KR Mike
MySQL Database 4-byte UTF-8 support
Thanks. Would you please file an issue at https://github.com/backdrop/backdrop-issues/issues? The idea there is to say that a site that uses a DB prefix defined in the simplified database...
MySQL Database 4-byte UTF-8 support
Yes, I added the port and driver lines and reloaded the website and the Status Report no longer has the error. I am unable to check the conversion link as I can no longer see it.
MySQL Database 4-byte UTF-8 support
OK, so, did you use what I suggested to fix it? Can you be more specific? If you did, then this is a bug that needs to be reported in the issue queue. Please verify.
MySQL Database 4-byte UTF-8 support