Taxonomy vocabularies and PHP 8.2 - needs direction / decision.
Core support for PHP 8.2 is on its way. In a previous pull request, we decided to check for property existence in function taxonomy_form_vocabulary_submit() to prevent arbitrary form item values to bloat the object, but it turns out, that's not sufficient and possibly not even appropriate.
Looking at official documentation, it seems like class TaxonomyVocabulary is actually supposed to allow dynamic properties. We just didn't realize, as hook_taxonomy_vocabulary_load() isn't used anywhere in core. And there's no functional test for that hook, either.
Thanks Meaghan. I have solved this error. The issue was that after the upgrade, I re-enabled the civicrm related modules at a time that leads to the error. But after that I tried and re enabled...
Posted1 day 2 hours ago by Sudipto Kumar Mitra (sudipto68) on:
Thanks for the quick response. Unfortunately I can't offer a PR - I'm not a coder, I'd say a designer and copywriter who also develops websites.
I'm not sure I can formulate the problem...
Posted1 day 15 hours ago by Antony Milenkov (amilenkov) on:
I didn't know there were so many untranslated strings in ubercart. Maybe the easiest would be to make a PR to ubercart to get those translated. Assuming there are no problems with that. ...
Comments
Taxonomy vocabularies and PHP 8.2 - needs direction / decision.
Core support for PHP 8.2 is on its way. In a previous pull request, we decided to check for property existence in function taxonomy_form_vocabulary_submit() to prevent arbitrary form item values to bloat the object, but it turns out, that's not sufficient and possibly not even appropriate.
Looking at official documentation, it seems like class TaxonomyVocabulary is actually supposed to allow dynamic properties. We just didn't realize, as hook_taxonomy_vocabulary_load() isn't used anywhere in core. And there's no functional test for that hook, either.
Issue #6197 provides more info.
The decision has notable impact on contrib modules.