Taxonomy vocabularies and PHP 8.2 - needs direction / decision.
Core support for PHP 8.2 is on its way. In a previous pull request, we decided to check for property existence in function taxonomy_form_vocabulary_submit() to prevent arbitrary form item values to bloat the object, but it turns out, that's not sufficient and possibly not even appropriate.
Looking at official documentation, it seems like class TaxonomyVocabulary is actually supposed to allow dynamic properties. We just didn't realize, as hook_taxonomy_vocabulary_load() isn't used anywhere in core. And there's no functional test for that hook, either.
Worth mentioning as it was in zulip chat by @yorkshirepudding
I just tested and the two work together without issue as long as you don't use the "Exclude comments from Content...
There is also Node Comments Search - this searches the node and all comments (default search is node and first page of comments) as part of the content search. Izzy's module above is a separate...
Posted1 week 13 hours ago by Martin Price | System Horizons Ltd (yorkshirepudding) on:
If there is no response, alternatively, you can use a View with a list of comments, with a filter based on the comment text. I haven't tried it myself, I just got an idea.
Comments
Taxonomy vocabularies and PHP 8.2 - needs direction / decision.
Core support for PHP 8.2 is on its way. In a previous pull request, we decided to check for property existence in function taxonomy_form_vocabulary_submit() to prevent arbitrary form item values to bloat the object, but it turns out, that's not sufficient and possibly not even appropriate.
Looking at official documentation, it seems like class TaxonomyVocabulary is actually supposed to allow dynamic properties. We just didn't realize, as hook_taxonomy_vocabulary_load() isn't used anywhere in core. And there's no functional test for that hook, either.
Issue #6197 provides more info.
The decision has notable impact on contrib modules.