Taxonomy vocabularies and PHP 8.2 - needs direction / decision.
Core support for PHP 8.2 is on its way. In a previous pull request, we decided to check for property existence in function taxonomy_form_vocabulary_submit() to prevent arbitrary form item values to bloat the object, but it turns out, that's not sufficient and possibly not even appropriate.
Looking at official documentation, it seems like class TaxonomyVocabulary is actually supposed to allow dynamic properties. We just didn't realize, as hook_taxonomy_vocabulary_load() isn't used anywhere in core. And there's no functional test for that hook, either.
There are some test failures in the user module after merging in the latest commits.
Randomly, only in one PHP version - and always a different one.
See also this Zulip...
Two issues would benefit from testing and code reviews; they've been around for a while and no takers. It would be a shame for these to miss the next releases.
View Table Headings...
Posted3 days 6 hours ago by Martin Price | System Horizons Ltd (yorkshirepudding) on:
For the dev meeting: Progress all over the place.
Nine pull requests are currently marked RTBC - time to consider merging? Bug fixes mostly, and not too complex.
Issue #6987: There's...
In a blog post titled "Github Tips and Tricks for Contrib Maintainers", I'd like to see some of the following topics:
When is the README sufficient for documentation? When should...
Posted4 days 22 hours ago by Olaf Grabienski (Olafski) on:
Comments
Taxonomy vocabularies and PHP 8.2 - needs direction / decision.
Core support for PHP 8.2 is on its way. In a previous pull request, we decided to check for property existence in function taxonomy_form_vocabulary_submit() to prevent arbitrary form item values to bloat the object, but it turns out, that's not sufficient and possibly not even appropriate.
Looking at official documentation, it seems like class TaxonomyVocabulary is actually supposed to allow dynamic properties. We just didn't realize, as hook_taxonomy_vocabulary_load() isn't used anywhere in core. And there's no functional test for that hook, either.
Issue #6197 provides more info.
The decision has notable impact on contrib modules.